Development record
the new Unadmitted clause in Empty is the one surviving mutation because Empty has no production caller
the new Unadmitted clause in Empty is the one surviving mutation because Empty has no production caller
Found by the round-2 adversarial ruthless review of build/itd-189, and it is the ONE survivor out of twenty-two mutations the reviewer ran against this branch's new guards. Twenty-one died.
Deleting len(r.Unadmitted) == 0 from Empty() (readingoutstanding.go:195)
leaves both internal/core/lint and internal/surface/cli green.
No failure today: Empty() has NO PRODUCTION CALLER -- only
reading_outstanding_test.go:313 -- so the clause is correct-but-unreachable
rather than wrong. It becomes a real silence the day a surface gates rendering
on Empty(), which is exactly the kind of latent hole that is cheap now and
expensive later.
The pre-existing dead method is not this branch's doing; the untested new clause is.
Frontmatter
| id | iss-2608301327012407 |
|---|---|
| type | issue |
| lifecycle | resolved |
| severity | nitpick |
.abcd/work/issues/resolved/iss-2608301327012407-the-new-unadmitted-clause-in-empty-is.md
open on GitHub ↗ · commit history ↗
mentions1
- itd-189What the widening reading proposes is admitted or declined on the record — grounds on admission, dispositions on declines, and surprises as their own entries