Development record
four correct guards in the outstanding report and the join have no killing test so each mutation survives the whole suite
four correct guards in the outstanding report and the join have no killing test so each mutation survives the whole suite
Found by the round-3 ruthless review, each proved by a surviving mutation. Every one is CORRECT code; what is missing is a test that dies without it.
readingoutstanding.go:362— the Unadmitted leg's stand-down on an unreadable run. Delete!admissions.unknown(run.Name())and the whole suite stays green, while the report then emits "is a widening proposal with neither an admission nor a decline" on the strength of a tree nobody read — possibly about the very admission that could not be read. The existing stand-down tests all use fixtures with NO standing disposition, so they exercise only the sibling stand-down at line 337. The reviewer wrote a 12-line probe (accepted disposition + oversized admission) that passes unmutated and kills the mutation.readingoutstanding.go:439— an admissions root that exists but cannot be listed setsrootUnreadable. Removing it survives: every widening proposal in every run would then be judged against a tree nobody listed.schema.go:839— the "a family this scan does not read supports no verdict" stand-down incheckRecordJoins. Removing it survives:occasioned_by: spike-3would draw a blocker saying it is not a record in the corpus, contradicting the leg's own "prose is legitimate and stays silent".schema.go:903—r.bucket == ""incheckRecordBucketFieldis UNREACHABLE (bucketFieldis declared only by the bucketedadmstore). This is the exact twin of the two stand-downs9d9024dadeleted IN THIS ROUND as "a branch no fixture can enter is how a guard comes to look tested" — one instance removed, its sibling left.
Why this record exists at all: 7a7dd1ed was raised in this same round because
the Unadmitted clause was the one guard no mutation could kill. The round fixed
that clause and left three more in the same file, plus an unreachable branch it
had just established a principle against.
Folded here rather than given ids of their own, both cosmetic: mark(judged, "slug") at schema.go:681 is redundant today (no store both requires slug and
lacks the issue-shape slug leg, and a blank slug always fails SlugRe), harmless
and arguably right as defence; and readingoutstanding.go:75 still says
"record_schema's sameBucket join" after 9d9024da renamed the field
sameBucketAs.
Frontmatter
| id | iss-2608301519254240 |
|---|---|
| type | issue |
| lifecycle | resolved |
| severity | minor |
.abcd/work/issues/resolved/iss-2608301519254240-four-correct-guards-in-the-outstanding.md
open on GitHub ↗ · commit history ↗
mentions3
- iss-2608301620343236the len(rs) != 1 guard in scriptioContinuaOnly is unreachable as called so no fixture can enter it
- iss-2608301634520703mark judged on id and on slug are both unreachable in the case they guard so removing either alone repeats the shape the round was convened for
- iss-2608301634527391the bucketField implies a bucketed store rule is asserted in prose only so a flat store declaring one would report filed under empty