Development record
three guards in the join and the outstanding report survive their own deletion and one equality check is inert by construction
three guards in the join and the outstanding report survive their own deletion and one equality check is inert by construction
Found by the round-5 ruthless review, reported as notes rather than findings. Recorded so they are not rediscovered as new.
Three guards survive their own deletion against the full lint and capture suite:
spellsHandleOf'srest == "": deleting it turns theproposal: rdi-finding into silence.checkRecordBucketField'sisAbsentValue(got): deleting it adds a second, weaker finding onrun: "".- the Unadmitted leg's
answer.standing.wellFormed: deleting it reports one item as bothUnreadableandUnadmitted.
Separately, admittedProposals' proposal == "" check is INERT rather than
defensive: readingItemFileRe guarantees the queried item is never empty, so
the map lookup it guards cannot be reached. That is the same class round 4 swept
in 31107a30, with one instance missed.
The reviewer also confirmed three sets of negative assertions are pinned to strings that occur nowhere in production code and so pass unconditionally. It did NOT report them as defects, and neither does this record: each sits beside a positive assertion on the current wording and each commit states the anti-regression intent. They are deliberate reintroduction pins. Noted only so a later reader does not mistake them for live coverage.
Frontmatter
| id | iss-2608301656202623 |
|---|---|
| type | issue |
| lifecycle | resolved |
| severity | nitpick |
.abcd/work/issues/resolved/iss-2608301656202623-three-guards-in-the-join-and-the.md
open on GitHub ↗ · commit history ↗