Development record
three nits from the itd-189 delta ruthless review including a godoc whose ordinals no longer match the code order
issueresolvednitpickiss-2608301813259334
three nits from the itd-189 delta ruthless review including a godoc whose ordinals no longer match the code order
Three nits from the itd-189 delta ruthless review, settled at the ship commit rather than by re-opening a review.
checkRecordJoins's godoc now reads first SPELLING, second PRESENCE, fourth POSITION, third BUCKET. The new paragraph was inserted above the one it follows in code, so the ordinals no longer match the order.iss-2608301744300631enumerates[]and{}for the gate versusdescribeADRdisagreement but omits!!null, which the same widening introduced and which behaves identically. The stated remedy already covers it; only the enumeration is short.commands/capture.mdlists thegroundsandproposalrefusals that hold today but not the two join refusals now armed onproposal: a target in another run, and a target outside the widening position.
Grounds
- pursued: a reader following the godoc meets the legs in the order numbered and capture.md names every refusal record_schema arms on proposal; a refusal the page omits would show it wrong
Frontmatter
| id | iss-2608301813259334 |
|---|---|
| type | issue |
| lifecycle | resolved |
| severity | nitpick |
.abcd/work/issues/resolved/iss-2608301813259334-three-nits-from-the-itd-189-delta.md
open on GitHub ↗ · commit history ↗
mentions2
- iss-2608301744300631an empty collection in superseded_by is an absence to the gate and a rendered link to record Describe so the two readers disagree about whether the record names a successor
- itd-189What the widening reading proposes is admitted or declined on the record — grounds on admission, dispositions on declines, and surprises as their own entries