Development record
four nits from the itd-189 fix delta review including an inverted test failure message and an over broad negative loop
issueresolvednitpickiss-2608301901260461
four nits from the itd-189 fix delta review including an inverted test failure message and an over broad negative loop
Four nits from the itd-189 fix-delta ruthless review, settled at the ship commit.
schema_test.go-- a failure message is inverted and its verb is useless: it fires precisely when the gate does NOT read the value as absent, and prints a constantfalseinside that branch.schema_test.go-- the negative loop rejects the substrings "skipped" and "refuses" across EVERYrecord_schemafinding on those two paths rather than the duplicate-key one, so an unrelated future message on an admission or a disposition trips it with a misleading reason.commands/capture.md-- the spellings list names "an alias" as carrying nothing. An alias to a defined anchor carries the anchor's value; it passes the gate regardless, so only the "carry nothing" half is the overclaim. Adjacent to but distinct from iss-2608301808197261 item 4.schema_test.go-- a comment calls its list "the whole of what the enumeration claims", butcommands/capture.mdalso lists a block scalar holding nothing, which the pin omits because it isvalueEmpty's business rather thanisAbsentValue's. The two lists the test claims to bind are not the same set.
- Added from the fix-delta SECURITY review, which offered it as a nit rather
than a finding:
commands/capture.mddoes not nameNull/NULLor U+00A0 among the refused spellings, although both ARE refused. It errs in the safe direction -- an author using them gets a clear refusal rather than a silent pass -- and the doc's category framing ("a YAML null", "whitespace") arguably covers them. Folded here rather than given an id.
Grounds
- pursued: an unrelated record_schema message on those paths no longer trips the loop, and every spelling capture.md lists is one the gate refuses; a listed spelling that passes would show it wrong
Frontmatter
| id | iss-2608301901260461 |
|---|---|
| type | issue |
| lifecycle | resolved |
| severity | nitpick |
.abcd/work/issues/resolved/iss-2608301901260461-four-nits-from-the-itd-189-fix-delta.md
open on GitHub ↗ · commit history ↗
mentions2
- iss-2608301808197261four nits from the itd-189 delta security review including an unpinned bucket field stand down and a zero width space passing the gate
- itd-189What the widening reading proposes is admitted or declined on the record — grounds on admission, dispositions on declines, and surprises as their own entries