Development record
four nits from the itd-179 fix delta review including a body line offset that is one ahead of the rendered body
issueresolvednitpickiss-2608301908288212
four nits from the itd-179 fix delta review including a body line offset that is one ahead of the rendered body
Four nits from the itd-179 fix-delta ruthless review, settled at the ship commit.
record.go/frontmatter.go-- "body line N" counts fromfrontmatter.Split's body, which keeps the blank line after the closing delimiter, whilecapture's reader strips it. So the number is one ahead of the body a reader renders. The quoted opener text is the reliable locator;Split's doc claim that writer and readers judge the same bytes is true of the SECTION and off by one line of the offset.record.goandintent/grounds.go-- two doc claims say a bare body may be passed and comes back unchanged. No live caller passes one, andBodydoes not in fact take either: a text opening with a thematic break reads as a frontmatter opener and 67 bytes including the whole section are eaten. Unreachable today; the claim invites the caller that would reach it.record.go-- the ambiguity refusal always says "## Groundsheadings", but the pattern matches any depth, so a record with a### Groundssubsection is refused by a message naming a level it does not have.record.go-- the frontmatter-only splice gains a blank line the whole-file form did not produce. Cosmetic; no real record has an empty body.
Three more from the fix-delta SECURITY review, which returned PASS and offered these as nits. Item 2 above is the same claim it names independently, so the two reviews converged on it.
capture/serialize.go--frontmatterBoundsaccepts blank lines before the opening delimiter whileparseFrontmatterAndBody,frontmatter.Fieldsandfrontmatter.Splitall require line 0. The reviewer found 544 divergent shapes and then chased the worst one end to end: it FAILS CLOSED, both verbs refuse and the file is byte-identical afterwards with no draft minted. Adjacent to the open iss-2608270908348042.grounds/record.go-- the ambiguous-heading refusal names the count but no line numbers, where its siblingreadBackRefusalnames a body-relative line and quotes the opener. Same file, two standards of diagnosis.capture/roots.go--readWithChecksumis uncapped where intent records get 256 KiB, so the refusal's%qcan quote an arbitrarily long body line into an error string. Cosmetic.
Grounds
- pursued: every append refusal now names a line an operator finds in the body the reader renders and quotes it bounded; a refusal naming the line below the opener, or the writer accepting a leading-blank record, would show it wrong
Frontmatter
| id | iss-2608301908288212 |
|---|---|
| type | issue |
| lifecycle | resolved |
| severity | nitpick |
.abcd/work/issues/resolved/iss-2608301908288212-four-nits-from-the-itd-179-fix-delta.md
open on GitHub ↗ · commit history ↗
mentions2
- iss-2608270908348042five delimiter-compare variants remain beside the canonical frontmatter.IsDelimiter: gate-side TrimSpace compares in lint and glossary accept an indented delimiter the canonical rule refuses, intent and changelog carry tolerant local copies, memory keeps its own close predicate, and site tests a bare HasPrefix — one consolidation pass onto the canonical predicate closes the family
- itd-179The reasoning behind what was pursued no longer evaporates at the gate — readiness and triage record grounds for the conjecture, not only the decision