Development record
Two scanner test nits from review 3: meter_test.go:196 pins the separator-run cap with a true account position (C:\Users followed by 65 backslashes), which passes with or without the cap, so the over-report direction for a rootless run is not itself pinned; and the meter fixtures scale with maxSeparatorRun, so inflating the constant to probe the no-cap case allocates gigabyte strings (remove the loop bound instead).
issueresolvedminoriss-2609251728586400
Two scanner test nits from review 3: meter_test.go:196 pins the separator-run cap with a true account position (C:\Users followed by 65 backslashes), which passes with or without the cap, so the over-report direction for a rootless run is not itself pinned; and the meter fixtures scale with maxSeparatorRun, so inflating the constant to probe the no-cap case allocates gigabyte strings (remove the loop bound instead).
Grounds
- pursued: removing the separator-run bound from endsWithPathFold now fails TestBoundedContextHelpersKeepTheFinding; that mutation passing, or a fixture again derived from maxSeparatorRun, would show it wrong
Frontmatter
| id | iss-2609251728586400 |
|---|---|
| type | issue |
| lifecycle | resolved |
| severity | minor |
.abcd/work/issues/resolved/iss-2609251728586400-two-scanner-test-nits-from-review-3.md
open on GitHub ↗ · commit history ↗