Development record
The reader-site test of the shell guard (unknownsites_test.go) detects a function that reads a word dash only by the shapes the package uses today (strings.HasPrefix with a dash literal, a comparison with a dash); a reader written as a switch on the first byte, strings.IndexByte, bytes.HasPrefix or a named dash constant would pass unlisted (review4-guard finding 5).
issueresolvedminoriss-2609252120215841
The reader-site test of the shell guard (unknownsites_test.go) detects a function that reads a word dash only by the shapes the package uses today (strings.HasPrefix with a dash literal, a comparison with a dash); a reader written as a switch on the first byte, strings.IndexByte, bytes.HasPrefix or a named dash constant would pass unlisted (review4-guard finding 5).
Grounds
- pursued: a reader of a word's dash written in any spelling is found and must be listed; a spelling the meta-test feeds it that it misses would show it wrong
Frontmatter
| id | iss-2609252120215841 |
|---|---|
| type | issue |
| lifecycle | resolved |
| severity | minor |
.abcd/work/issues/resolved/iss-2609252120215841-the-guard-reader-site-test-finds-dash.md
open on GitHub ↗ · commit history ↗