Development record
Three ahoy install writes still swallow their errors, the class iss-227 fixed for their siblings: the identity pin (stepIdentityPin drops a failed identity.WritePin, and an unset git identity, without a word), the .gitignore visibility block (stepVisibility drops applyVisibilityBlock's error), and the conventions-file marker block (stepMarker drops installMarkerFile and removeMarkerFile failures). A run that wrote none of them reports with no reason.
issueresolvedminoriss-2609260057127611
Three ahoy install writes still swallow their errors, the class iss-227 fixed for their siblings: the identity pin (stepIdentityPin drops a failed identity.WritePin, and an unset git identity, without a word), the .gitignore visibility block (stepVisibility drops applyVisibilityBlock's error), and the conventions-file marker block (stepMarker drops installMarkerFile and removeMarkerFile failures). A run that wrote none of them reports with no reason.
Grounds
- pursued: no install write fails silently; TestIdentityPinFailureIsNoted, TestGitignoreBlockFailureIsNoted and TestMarkerBlockFailureIsNoted would fail if any of the three dropped its failure again
Frontmatter
| id | iss-2609260057127611 |
|---|---|
| type | issue |
| lifecycle | resolved |
| severity | minor |
.abcd/work/issues/resolved/iss-2609260057127611-three-ahoy-install-writes-still-swallow.md
open on GitHub ↗ · commit history ↗
mentions1
- iss-227installDevShim silently swallows failures: the os.Remove, MkdirAll, and WriteFileAtomic error paths are bare returns (internal/core/ahoy/apply.go, installDevShim), so a failed shim write yields status=partial or clean with no note explaining what was not done or why; only the success path calls a.note