Development record
abcd site setup rewrites an existing deployment environment through PUT /repos/{r}/environments/{env} with only deployment_branch_policy in the body, and that endpoint replaces the whole protection set, so a site environment carrying required reviewers, a wait timer or prevent_self_review loses them after a confirmation that names only a branch restriction (setup.go plan.put, forge.go PutEnvironment).
issueresolvedmajoriss-2609260120383554
abcd site setup rewrites an existing deployment environment through PUT /repos/{r}/environments/{env} with only deployment_branch_policy in the body, and that endpoint replaces the whole protection set, so a site environment carrying required reviewers, a wait timer or prevent_self_review loses them after a confirmation that names only a branch restriction (setup.go plan.put, forge.go PutEnvironment).
Grounds
- pursued: an existing environment's reviewers and wait timer survive any setup run; a forge write to the environment endpoint for an environment that already exists would show it wrong
Frontmatter
| id | iss-2609260120383554 |
|---|---|
| type | issue |
| lifecycle | resolved |
| severity | major |
.abcd/work/issues/resolved/iss-2609260120383554-abcd-site-setup-rewrites-an-existing.md
open on GitHub ↗ · commit history ↗
mentions1
- itd-2609061543533170One verb takes a managed repository's site from the checkout to a live address