Development record
scribe ingest's per-line state check splits the supplied dispositions on LF alone, so a text whose lines end in CR, U+2028 or U+2029 is one line and the check collapses to a whole-text test: '{0}: rejected ... CR {1}: accepted ... CR' wrote {0} accepted (probed by review2-scribe; CRLF is unaffected). lineCarries in internal/core/scribe/ingest.go must split on CRLF, CR, LF, U+2028 and U+2029.
issueresolvedminoriss-2609261205176571
scribe ingest's per-line state check splits the supplied dispositions on LF alone, so a text whose lines end in CR, U+2028 or U+2029 is one line and the check collapses to a whole-text test: '{0}: rejected ... CR {1}: accepted ... CR' wrote {0} accepted (probed by review2-scribe; CRLF is unaffected). lineCarries in internal/core/scribe/ingest.go must split on CRLF, CR, LF, U+2028 and U+2029.
Grounds
- pursued: TestScribeIngestHoldsTheStateToTheItemsLineWhateverEndsIt refuses a state carried only by the next line under every terminator and lands the rulings the lines give; a CR, U+2028 or U+2029 subtest writing the next line's state would show it wrong
Frontmatter
| id | iss-2609261205176571 |
|---|---|
| type | issue |
| lifecycle | resolved |
| severity | minor |
.abcd/work/issues/resolved/iss-2609261205176571-scribe-ingest-s-per-line-state-check.md
open on GitHub ↗ · commit history ↗