Development record
The drain's history-walk notice (internal/surface/cli/intent_drain.go, runOwedDrain) prints site.LoadHistory's error to stderr through termsafe.Sanitize alone, bypassing scrubPaths, so git's quoted stderr, which can name an absolute path inside the repository (a corrupt loose object is reported with the file it is stored in), reaches the terminal unredacted: the one print in the drain front door no redactor touches. Found by review3-drain as a nit.
issueresolvedminoriss-2609261327506636
The drain's history-walk notice (internal/surface/cli/intent_drain.go, runOwedDrain) prints site.LoadHistory's error to stderr through termsafe.Sanitize alone, bypassing scrubPaths, so git's quoted stderr, which can name an absolute path inside the repository (a corrupt loose object is reported with the file it is stored in), reaches the terminal unredacted: the one print in the drain front door no redactor touches. Found by review3-drain as a nit.
Grounds
- pursued: a failed history walk whose git stderr names an absolute repository path prints it relative; a notice carrying the absolute path would show it wrong
Frontmatter
| id | iss-2609261327506636 |
|---|---|
| type | issue |
| lifecycle | resolved |
| severity | minor |
.abcd/work/issues/resolved/iss-2609261327506636-drain-history-notice-bypasses-scrubpaths.md
open on GitHub ↗ · commit history ↗