Development record
The ahoy install 'changed:' line reaches the terminal unsanitised, and itd-63 put external process output on it: the verify program's first line (and a failed step's output tail) enters tools.Result.Output raw, flows through Summary() into the ahoy result's changes and notes, and cli.go prints the changes without termsafe, so an escape sequence or bidi control in a program's output rewrites the report.
issueresolvedminoriss-2609261604498137
The ahoy install 'changed:' line reaches the terminal unsanitised, and itd-63 put external process output on it: the verify program's first line (and a failed step's output tail) enters tools.Result.Output raw, flows through Summary() into the ahoy result's changes and notes, and cli.go prints the changes without termsafe, so an escape sequence or bidi control in a program's output rewrites the report.
Grounds
- pursued: every render of a tools result carries the program's text with no control rune; a Summary or Output that still holds ESC, U+009B or a bidi override after a hostile program's output would show it wrong
Frontmatter
| id | iss-2609261604498137 |
|---|---|
| type | issue |
| lifecycle | resolved |
| severity | minor |
.abcd/work/issues/resolved/iss-2609261604498137-the-ahoy-install-changed-line-reaches.md
open on GitHub ↗ · commit history ↗
mentions1
- itd-63The Amateur Coder Is Told What Is Being Installed And Why, Not Just Asked To Run A Command