Development record
namesCodeOwners (internal/core/implement/loop/land.go) is looser than the forge's CODEOWNERS parse: it counts any non-comment line as naming an owner and ORs all three CODEOWNERS locations, so a code-owner review arms auto-merge where the forge asks nobody: a line '* @' (an owner-less token), a pattern-only line, and a comment-only .github/CODEOWNERS shadowing a root CODEOWNERS that names an owner each arm (review-amApproval, minor).
issueresolvedminoriss-2609302205483845
namesCodeOwners (internal/core/implement/loop/land.go) is looser than the forge's CODEOWNERS parse: it counts any non-comment line as naming an owner and ORs all three CODEOWNERS locations, so a code-owner review arms auto-merge where the forge asks nobody: a line '* @' (an owner-less token), a pattern-only line, and a comment-only .github/CODEOWNERS shadowing a root CODEOWNERS that names an owner each arm (review-amApproval, minor).
Grounds
- pursued: a code-owner review arms only where the forge would ask a named owner; TestTheLandingArmsOnlyWhereTheRulesetRequiresApproval's bare-@, pattern-only and shadowing cases went red before the fix and green after, and this repository's own mirror still arms. A CODEOWNERS owner shape the forge accepts that codeOwner refuses (left open where it would arm) would show it wrong.
Frontmatter
| id | iss-2609302205483845 |
|---|---|
| type | issue |
| lifecycle | resolved |
| severity | minor |
.abcd/work/issues/resolved/iss-2609302205483845-namescodeowners-internal-core-implement.md
open on GitHub ↗ · commit history ↗