Development record
When ahoy install's settings write does not land, stepConfigValues' rollbackForced (internal/core/ahoy/apply.go) clears the whole change list (a.changes = nil), not only the override echoes stepConfigValues itself added, so a dependency receipt stepDependencies recorded earlier in the same run (a tool installed and verified) is dropped from the result: the person is not told of a tool that was installed.
issueresolvedminoriss-2610031915495759
When ahoy install's settings write does not land, stepConfigValues' rollbackForced (internal/core/ahoy/apply.go) clears the whole change list (a.changes = nil), not only the override echoes stepConfigValues itself added, so a dependency receipt stepDependencies recorded earlier in the same run (a tool installed and verified) is dropped from the result: the person is not told of a tool that was installed.
Grounds
- pursued: an unsaved settings change returns the change list exactly as earlier steps left it; TestUnsavedSettingsKeepEarlierReceipts preloads a receipt and fails with the rollback clearing the whole list, so a regression to a.changes = nil would show it wrong
Frontmatter
| id | iss-2610031915495759 |
|---|---|
| type | issue |
| lifecycle | resolved |
| severity | minor |
.abcd/work/issues/resolved/iss-2610031915495759-when-ahoy-install-s-settings-write-does.md
open on GitHub ↗ · commit history ↗