Development record
Marker refusal notes carry the conventions file's absolute path through the wrapped OS error: installMarkerFileLocked and removeMarkerFileLocked (internal/core/ahoy/marker.go) wrap the guarded read's error with 'it could not be read: %w', and embark's dry-run refusal (internal/core/ahoy/embark_marker.go) does the same, so the embark result's note, rendered and in --json, prints the target's full path, the account name included, wherever the file cannot be read.
issueresolvedminoriss-2610032202259011
Marker refusal notes carry the conventions file's absolute path through the wrapped OS error: installMarkerFileLocked and removeMarkerFileLocked (internal/core/ahoy/marker.go) wrap the guarded read's error with 'it could not be read: %w', and embark's dry-run refusal (internal/core/ahoy/embark_marker.go) does the same, so the embark result's note, rendered and in --json, prints the target's full path, the account name included, wherever the file cannot be read.
Grounds
- pursued: TestMarkerRefusalsCarryNoPath and TestEmbarkProbePredictsAnUnwritableRoot assert no install note, EnsureMarker error, removeMarkerFile error or embark note carries the target's directory; any of them carrying it would show it wrong
Frontmatter
| id | iss-2610032202259011 |
|---|---|
| type | issue |
| lifecycle | resolved |
| severity | minor |
.abcd/work/issues/resolved/iss-2610032202259011-marker-refusal-notes-carry-the.md
open on GitHub ↗ · commit history ↗