Development record
The brief's launch chapter's refusal-kinds table describes unfixed-finding as the consequential (major/critical) finding case only, while the guardrail list forty lines below now says it also fires for an open issue record that differs from HEAD (added by the drain lane for iss-2610072347238476, which left the table row alone because a peer's verb split edits nearby). The table and the list now disagree within one chapter.
issueresolvednitpickiss-2610101803326081
The brief's launch chapter's refusal-kinds table describes unfixed-finding as the consequential (major/critical) finding case only, while the guardrail list forty lines below now says it also fires for an open issue record that differs from HEAD (added by the drain lane for iss-2610072347238476, which left the table row alone because a peer's verb split edits nearby). The table and the list now disagree within one chapter.
Grounds
- pursued: the table row, the guardrail list, commands/launch.md and Emit's three RefusalUnfixedFinding appends all describe the same two cases; a row that again names only one case, or Emit raising unfixed-finding for a case the row does not name, would show it wrong, and TestBriefRefusalKindsRowForUnfixedFindingNamesBothCases fails on the first.
Frontmatter
| id | iss-2610101803326081 |
|---|---|
| type | issue |
| lifecycle | resolved |
| severity | nitpick |
.abcd/work/issues/resolved/iss-2610101803326081-the-brief-s-launch-chapter-s-refusal.md
open on GitHub ↗ · commit history ↗
mentions2
- iss-2610072347238476commands/launch.md and the brief's launch chapter describe the unfixed-finding refusal as major/critical-only, but the findings gate now also emits it for any open issue record that differs from HEAD; and when unfixed or deleted findings are present too, the uncommitted paths appear only in --json, so the operator loops once more before seeing them.
- iss-2610112036089151The FindingGuardFailed doc comment in internal/core/changelog/findings.go says the guard fails when 'a consequential finding this cycle produced is still open and unwaived', but GuardFindings also fails on an open issue record that differs from HEAD (at any severity) and on deleted records, so the comment states one case of three. A sibling of iss-2610101803326081, whose lane fixed the launch brief's table row and RefusalUnfixedFinding's comment in release/emit.go and left this second package for capture.