Development record
The guard's question check lets a question without abcd's label through without a word when git cannot name the repository root for a directory that looks like a repository. The hook writes nothing at all: an empty stdout, exit 0 and an empty stderr. The guard's own rule is to fail open, but loudly. On a loaded machine this silence was what TestModeMadeQuestionAbcdsSaysSo met on PR #858, before f1703a29f removed the 50ms root-lookup deadline. The silent branch is still there for any other reason the lookup fails.
issueresolvedminoriss-2610110432159652
The guard's question check lets a question without abcd's label through without a word when git cannot name the repository root for a directory that looks like a repository. The hook writes nothing at all: an empty stdout, exit 0 and an empty stderr. The guard's own rule is to fail open, but loudly. On a loaded machine this silence was what TestModeMadeQuestionAbcdsSaysSo met on PR #858, before f1703a29f removed the 50ms root-lookup deadline. The silent branch is still there for any other reason the lookup fails.
Frontmatter
| id | iss-2610110432159652 |
|---|---|
| type | issue |
| lifecycle | resolved |
| severity | minor |
.abcd/work/issues/resolved/iss-2610110432159652-question-check-fails-open-silently.md
open on GitHub ↗ · commit history ↗
mentions1
- iss-2610121056562293When git will not name the repository root inside a checkout, a question that carries abcd's label is still checked against the field limits, but if it passes, the guard's question check cannot set the status-line badge or mark the question open, and it says nothing about that: the person and the transcript cannot tell the bookkeeping was skipped. The unlabelled case now says so (iss-2610110432159652); the labelled case is still silent.