Development record
addEmbargoed's dropClosedTitles is a bare positional bool, so a future third caller could pass the wrong value and either leak a closed advisory's title into a publication text or refuse every range on a merge title, with no compiler help; both current callers are correct and each direction is pinned by a test.
issueresolvednitpickiss-2610142334360850
addEmbargoed's dropClosedTitles is a bare positional bool, so a future third caller could pass the wrong value and either leak a closed advisory's title into a publication text or refuse every range on a merge title, with no compiler help; both current callers are correct and each direction is pinned by a test.
Grounds
- pursued: a bool no longer compiles at a call site, and the range set still drops a closed advisory's title while the publication set keeps it; TestAddEmbargoedTakesANamedMode, TestRangeDenySetDropsClosedTitles, TestPublicationDenySetKeepsClosedTitles or TestAddEmbargoedModes failing would show it wrong
Frontmatter
| id | iss-2610142334360850 |
|---|---|
| type | issue |
| lifecycle | resolved |
| severity | nitpick |
.abcd/work/issues/resolved/iss-2610142334360850-embargo-deny-set-mode-is-a-bare-bool.md
open on GitHub ↗ · commit history ↗