Development record
make precheck chooses the command and site packages' audit tests by a word in their names (PRECHECK_AUDIT_TESTS), and nothing checks that a new test reading the committed tree carries one: an audit test named outside the pattern runs in preflight but not in precheck, so a lane can pass precheck and still lose a preflight slot to it. A structural detector was tried and set aside: about 250 command-package tests reach the repository root, most to run scripts and hooks rather than to audit prose, so 'reads the root' does not tell an audit from a behaviour test.
make precheck chooses the command and site packages' audit tests by a word in their names (PRECHECK_AUDIT_TESTS), and nothing checks that a new test reading the committed tree carries one: an audit test named outside the pattern runs in preflight but not in precheck, so a lane can pass precheck and still lose a preflight slot to it. A structural detector was tried and set aside: about 250 command-package tests reach the repository root, most to run scripts and hooks rather than to audit prose, so 'reads the root' does not tell an audit from a behaviour test.
On 5 November this cost three preflight slots: internal/reachaudit twice and internal/abcdhome's boundary test once, each met 30 to 45 minutes in after precheck had passed. Precheck now names both packages, by hand, and nothing yet fails when a new audit package is left out.
Frontmatter
| id | iss-2610230048490215 |
|---|---|
| type | issue |
| lifecycle | open |
| severity | minor |
.abcd/work/issues/open/iss-2610230048490215-precheck-s-audit-test-pattern-is-a.md
open on GitHub ↗ · commit history ↗