Development record
The reserved review-verdict enum is SHIP/NEEDS_WORK/MAJOR_RETHINK, but the build loop parses SHIP/FIX FIRST and APPROVE/BLOCK/NEEDS-INPUT as review verdicts
The reserved review-verdict enum is SHIP/NEEDS_WORK/MAJOR_RETHINK, but the build loop parses SHIP/FIX FIRST and APPROVE/BLOCK/NEEDS-INPUT as review verdicts
A terminology drift (severity minor) found by the cross-document consistency pass.
- End A:
.abcd/development/brief/02-constraints/04-naming.md:187— "Review verdicts ∈{SHIP, NEEDS_WORK, MAJOR_RETHINK}| Carmack-style review verdicts" - End B:
.abcd/development/brief/04-surfaces/34-build.md:696— "stating one verdict of its role (SHIPorFIX FIRST;APPROVE,BLOCKorNEEDS-INPUT)"
The naming register lists review verdicts as a controlled enum of exactly SHIP, NEEDS_WORK and MAJOR_RETHINK. The build chapter has the loop read each reviewer's one verdict as SHIP or FIX FIRST (and APPROVE, BLOCK or NEEDS-INPUT), tokens the register does not hold. Either the enum is not the closed list of review verdicts, or the loop parses verdicts outside it. A builder working from the register would reject the loop's tokens.
Evidence: .abcd/work/reviews/2026-10-26-consistency/00-summary.md, finding 70.
Grounds
- declined: Closed in the 2026-10-27 triage (dcn-2610271112330536) as a duplicate of iss-2610262030580466. Same A end and same root cause: the register's closed review-verdict list is lifeboat-only while the build loop parses SHIP/FIX FIRST and APPROVE/BLOCK/NEEDS-INPUT, which 01-agents.md already calls each role's own words.
Frontmatter
| id | iss-2610262030597155 |
|---|---|
| type | issue |
| lifecycle | wontfix |
| severity | minor |
.abcd/work/issues/wontfix/iss-2610262030597155-the-reserved-review-verdict-enum-is-ship.md
open on GitHub ↗ · commit history ↗
mentions2
- dcn-26102711123305362026-10-27 — The product thinker accepted on 2026-10-27 the triage of the 1301 records the 2026-10-26 consistency pass filed. The duplicates, the records a later record already settles, the ones that are no contradiction and the one already fixed are closed with each reader's reason. Every other record gets its fix as its remedy, the rulings' accepted answers included, so a drain can take it. The 45 major records left open are deferred past v0.15.1, because the brief's single-home rewrite rewrites or removes most of the passages they quote. The person ruled the major rulings one at a time; the minor rulings take their recommended answers.
- iss-2610262030580466The reserved-vocabulary register fixes review verdicts as SHIP / NEEDS_WORK / MAJOR_RETHINK; the docs chapter's saved docs review returns PROMOTE, HOLD or INCONCLUSIVE, which the register does not hold.