Development record
abcd drain --unskip names the wrong thing when the issue it is given is held back by a path: with internal/core held back, --unskip iss-A for an issue whose found_at lies in internal/core says iss-A was not held back, while the same move lists iss-A among the held-back issues (applySkips in internal/core/implement/loop/drain_skip.go). The command that would lift the hold, --unskip internal/core, is still shown, so nothing is lost, but the summary line is false. Found by the round-2 ruthless review of itd-82 lane-1 (build/run-2610260500113538-lane-1).
issueopenminoriss-2610270934594826
abcd drain --unskip names the wrong thing when the issue it is given is held back by a path: with internal/core held back, --unskip iss-A for an issue whose found_at lies in internal/core says iss-A was not held back, while the same move lists iss-A among the held-back issues (applySkips in internal/core/implement/loop/drain_skip.go). The command that would lift the hold, --unskip internal/core, is still shown, so nothing is lost, but the summary line is false. Found by the round-2 ruthless review of itd-82 lane-1 (build/run-2610260500113538-lane-1).
Frontmatter
| id | iss-2610270934594826 |
|---|---|
| type | issue |
| lifecycle | open |
| severity | minor |
.abcd/work/issues/open/iss-2610270934594826-abcd-drain-unskip-names-the-wrong-thing.md
open on GitHub ↗ · commit history ↗
mentions1
- itd-82`abcd drain` fixes the issues that need no decision, and hands the rest back by kind